Skip to content

fix(m8): validate private host output before continuing - #235

Merged
sushiHex merged 7 commits into
mainfrom
fix/q13-output-guards
Oct 18, 2026
Merged

sushiHex merged 7 commits into
mainfrom
fix/q13-output-guards

Conversation

@sushiHex

@sushiHex sushiHex commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Final head: 9bcd249420968d8668af94d1d7675f589140cf74, based on merged PR #236 at 459cc77. Exact-head verification, qualification and all four containment lanes are green. The focused confirming connector review completed with no findings; both earlier threads are resolved.

Scope

Validate private drift output inside the reviewed step, before later commands: supplied tool digest, exact bounded expected stdout including final LF, empty stderr and zero direct-child status. Record launch requested separately from observed completion. Raw captures remain private and exclusive.

G1 streams both child pipes to retained files and requires successful EOF on both before comparison. This corrects the reproduced descendant-write race; executor shutdown or child exit alone is insufficient. Drain errors refuse without certifying partial captures as complete.

The packager refuses unguarded drift calls and requires every G1-using step to declare each private input exactly once before its first guard. The earlier declaration and ordering gaps were reproduced and corrected. Repeated guards share one pair. Frozen q12 bytes retain historical assembly compatibility only. The offline preparation decision is included; no complete q13 procedure or execution go is supplied.

Evidence

  • Final-head full gate: 6,947 passed, 446 skipped, one warning; staged-controller check: one passed; Python 3.12 structural-channel suite: 14 passed. All mutation-inventory jobs passed. The quiet aggregate log does not provide individual guard-case results; the focused local results below do.
  • Both late-descendant stdout/stderr cases failed by assertion before the fix. Deterministic test-only socket barriers exercise real inherited writers without sleep-based pass criteria.
  • Complete guard/packager and mutation-inventory structural checks: 264 passed, one Windows privilege skip. Nine new cases include accepting silent descendants, both late-write refusals, either drain error and four assertion-sensitive completion-check mutations.
  • Rebased tree: 69 scope/manifest and new-case checks passed; final manifest check passed. Guard implementation, tests and G1 bytes match the tested pre-rebase fix. Merged scanner and qualification records are preserved.
  • Earlier declaration fix: all 37 packager inventory mutants were assertion-killed. Current inventory structure was checked; exact-head CI will rerun the inventories and full gate. Historical results are not substituted for that run.
  • Ruff and diff checks passed; changed plan documents were staged before manifest regeneration. Both introduced review findings have verified replies and resolved threads; confirming review is clean on this exact head.

Limits

Synthetic fixtures are not private-host measurements. No actual installed-tool digest or approved private expectation is supplied. Capture has no disk bound or timeout; inherited writers can hold EOF indefinitely. EOF is not process-tree termination. Hash-before-execution and capture-path integrity still rely on trusted custody. The lexical lint does not interpret arbitrary Bash control flow. No VM, credential, vendor/model action, qualification or complete pre-application rehearsal is claimed.

Refs #186 #226 #189

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T09:05:39.452001Z 9bcd249 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a12ed52257

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/m8_procedure_package.py Resolved
@sushiHex
sushiHex marked this pull request as draft October 18, 2026 07:53
@sushiHex
sushiHex force-pushed the fix/q13-output-guards branch from 5507cd8 to 24430ac Compare October 18, 2026 08:26
@sushiHex
sushiHex marked this pull request as ready for review October 18, 2026 08:29

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24430ac851

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Refs #226 #189. Add a reviewed in-step guard, bounded private hex expectation, installed-tool digest input, successor call coverage lint, and credential-free executable evidence. Preserve frozen q12 assembly only by exact document digest.
Refs #186 #226 #189

Agent-Lane: codex:constructicon-wave
Refs #226 #189. Reproduce the connector P1 through the production packager, require exactly one canonical expectation and tool-digest placeholder per G1-using step before its first guard, and test multi-step, inherited, literal, duplicate and late declarations. Keep repeated guards and the exact frozen q12 compatibility intact.

Agent-Lane: codex:constructicon-wave
Record the merged scanner scope and private guard limits, including the introduced declaration/order correction. Rebase onto 146920d preserves all guard implementation/test blobs and the scanner record; regenerate archive evidence from staged bytes.

Agent-Lane: codex:constructicon-wave
Refuse failed drains and capture inherited descendant writes before deciding the output contract. Add deterministic synthetic socket-barrier regressions and assertion-sensitive EOF/result mutants.

Agent-Lane: codex:constructicon-wave
Preserve the merged scanner and isolated qualification records, and record only the scoped post-rebase checks. Guard implementation and test bytes are unchanged.

Agent-Lane: codex:constructicon-wave
@sushiHex
sushiHex force-pushed the fix/q13-output-guards branch from 24430ac to 9bcd249 Compare October 18, 2026 09:01
@sushiHex

Copy link
Copy Markdown
Owner Author

@codex review Please confirm final head 9bcd249, focusing on the corrected inherited-writer race and drain-failure propagation. Both descendant cases were reproduced by assertion before the fix; exact evidence and limits are in the thread reply. The prior declaration correction is retained. No host or vendor execution is claimed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 9bcd249420

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sushiHex
sushiHex merged commit dc61d16 into main Oct 18, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant