Repository navigation
Rehearse Claude READ and bind its worker launch profile - #311
Conversation
Agent: codex:constructicon-wave
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Initial head d07e6ac: full verify/mutation gate and runner qualification passed; Source audit identified a concrete missing fixture precondition: the exact The narrow CI-only correction validates /opt ownership/canonical identity, Connector review completed on d07e6ac with no findings. No repeat broad review |
Agent: codex:constructicon-wave
Agent: codex:constructicon-wave
Separate the closed physical launch profile from vendor presence, retain strict probe predicates, and cover the actual assembly and refusals. Record the exposed production mismatch and fresh controller requirement. Agent: codex:constructicon-wave
|
At head 0c0acc0, the actual generated-chain rehearsal has exposed and corrected a pre-existing production READ assembly mismatch. The prior run measured a contradictory containment probe before dispatch, with zero callbacks; it did not retain separate native/worker label observations. Source tracing showed that the vendor-free API worker used Claude's policy but selected the generic expected profile. Existing physical-provider tests injected a different generic worker. The correction is a closed, revision-bound launch-profile selection independent of vendor identity. The worker remains vendor-free and networkless; physical probes still require one exact selected label and every existing containment predicate. No policy permissions, mounts, credentials, egress or protocol are changed. The READ materialization branch does not need Git execution in the bootstrap profile; the WRITE branch is outside this correction. Focused API/recipe/read-worker/host-session tests and strict typing passed. All six new distinct profile mutants were killed by assertion failures, and inventory target/collection checks passed. Terra independently reviewed the profile boundary and compatibility delta with no confirmed blocker. This narrow review supplements the connector's initial d07e6ac review; that earlier review is not claimed to cover the new controller code. The full verification/qualification/physical gates must now pass on 0c0acc0, including the actual generated accepting READ chain and abort withdrawal. No private-host retry occurred. Because controller source and identity changed, the old private controller candidate is invalidated; a newly reviewed exact installation and fresh qualification are required before a live attempt. |
|
Final head 0c0acc0 is green. Full verification and mutation CI passed: The required generated-chain step executed both cases: the accepting path completed the actual fixed READ and generation-bound withdrawal; the injected post-activation refusal also completed generation-bound withdrawal. These are credential-free fake-vendor observations, not a private-host or subscription READ claim. No frozen plan bytes changed. The final conversation/review/inline check found no unaddressed finding. Initial connector review and the recorded narrow independent fixture/profile reviews cover the delivered changes. Squash merging under the owner's authorization. For later Windows execution, preparation must use a byte-exact Git source image for local qualification-source hashing; CRLF-translated working copies are not identical to the installed LF controller source. The comparison stays strict. The old private candidate remains invalidated; no private installation or model attempt has occurred in this work. |
Make the bounded Claude READ procedure runnable through versioned one-phase operator tooling, and rehearse its actual generated commands and produced receipts without credentials. Private bindings remain external; the operator-tool content revision and installed controller commit are distinct inputs.
The real accepting rehearsal exposed a pre-existing production assembly bug: the vendor-free READ worker uses Claude's launch policy, but its physical probe selected the generic workload label from vendor presence. A closed, revision-bound launch-profile selection now states the correct worker policy independently of vendor identity. The probe still requires one exact enforcing label and all existing containment predicates. No policy, protocol, mount, credential or egress authority is widened.
Risk tier: consequential. Portable tests exercise actual CLI/package/receipt behavior and profile accepting/refusing cases. The required foundation step executes the full generated chain with a real installed test controller/store/lane and a compiled harmless peer; actual outputs feed subsequent steps, including withdrawal after a post-activation refusal. Failed phases retain bounded diagnostics before cleanup. The other physical lanes and full verification remain required. Final-head results are recorded in this PR before merge.
Review: connector review completed without findings on initial operator implementation d07e6ac. The hosted fixture corrections and the newly exposed controller-profile boundary receive narrow independent review; that original review is not represented as covering the later source change.
Limits: SSH/SCP are local process-boundary doubles; drift is a measured test-scoped double. This does not qualify a vendor or enable a production provider. The controller source correction requires a newly reviewed installation pin and fresh qualification before the separately authorized live attempt; the old controller approval is not silently reused. Frozen plans remain unchanged.
Refs #40