Add werkzeug ProxyFix X-Forwarded-Prefix support #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaek
force-pushed
the
proxyfix-forwarded-prefix
branch
from
fad23c4 to
02a8dbd
Compare
The base url is not the same as the blueprint mount point because the blueprint url is relative to the application context root.
So either the jinja template needs to be altered to use relative urls, or the base_url should be determined per request.
This commit changes the base_url to url_for(".show"), this makes the UI work for both proxied and direct requests.
sjaek
force-pushed
the
proxyfix-forwarded-prefix
branch
from
02a8dbd to
3f6b313
Compare
|
Actual problem +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base url is not the same as the blueprint mount point because the blueprint url is relative to the application context root.
So either the jinja template needs to be altered to use relative urls, or the base_url should be determined per request.
This commit changes the base_url to url_for(".show"), this makes the UI work for both proxied and direct requests.