feat: add Svelte 5 support to no-not-function-handler#1013
Conversation
🦋 Changeset detectedLatest commit: e0b77ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
| verify(node.expression); | ||
| }, | ||
| SvelteAttribute(node) { | ||
| if (node.key.type === 'SvelteName' && node.key.name.startsWith('on')) { |
There was a problem hiding this comment.
I don't know if that's actually the case, but I'm worried that there might be false positives for components with properties like one, only, once, and online. 🤔
I think maybe we should ignore component attributes from the check. What do you think?
There was a problem hiding this comment.
Yes. We need to take every events from here.
https://github.com/sveltejs/svelte/blob/a129592e5b248a734a68da6e9028941803a3d063/packages/svelte/elements.d.ts#L83
baseballyama
force-pushed
the
feat/no-not-function-handler
branch
from
f7a3556 to
1266f5b
Compare
baseballyama
force-pushed
the
feat/no-not-function-handler
branch
from
2e2b6f0 to
e0b77ba
Compare
2 participants
I updated docs also. (
on:click->onclick)