feat: implemented the valid-style-parse rule

[marekdedic]

Closes #509

[changeset-bot]

🦋 Changeset detected

Latest commit: 2ee6d7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-svelte	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[marekdedic]

There is some issue in the pkg.pr.new action, I don't think it's related to anything in this PR...

[github-actions]

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@1054

Published Instant Preview Packages:

• eslint-plugin-svelte: https://pkg.pr.new/eslint-plugin-svelte@1054

View Commit

[ota-meshi]

The workflow has been fixed 😄
I've rebased this PR so please apply it to your local too.

[ota-meshi]

Thank you for this PR!
It looks mostly good to me, but I have a few comments.

[marekdedic]

@ota-meshi I can't solve the update error - The update script fails on the invalid CSS, which makes sense. I tried wrapping the writeAndFormat function with a try/catch block, but for some reason, the error isn't getting caught there. I suspect it is actually caught somewhere in prettier and printed to stderr directly from there..

BTW, that function can be simplified to:

export async function writeAndFormat(fileName: string, content: string): Promise<void> {
	fs.writeFileSync(fileName, content, 'utf8');
	const prettierrc = await prettier.resolveConfig(fileName);
	const formatted = await prettier.format(content, { filepath: fileName, ...prettierrc });
	fs.writeFileSync(fileName, formatted, 'utf8');

	const eslint = new ESLint({ fix: true });
	const [result] = await eslint.lintText(formatted, { filePath: fileName });
	if (result.output) {
		fs.writeFileSync(fileName, result.output, 'utf8');
	}
}

[ota-meshi]

It seems that prettier will output a log and continue processing even if it fails to parse the style.
If we want to avoid logging, we will need to write <!-- prettier-ignore --> above the code block. However, prettier works, so it is not necessary for now.

[ota-meshi]

LGTM! Thank you!

[marekdedic]

Thanks, I tried adding the prettier ignore commands, but I couldn't get it to work either :/