-
-
Notifications
You must be signed in to change notification settings - Fork 60
add svelte/no-extra-reactive-curlies rule
#201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add svelte/no-extra-reactive-curlies rule
#201
Conversation
svelte/no-unnecessary-reactive-curlies rule
|
What do you think about rename the rule to |
|
I didn't explain it, use the |
ota-meshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
I have some change requests.
This is what I see as output This one in particular seems like a likely culprit with the doubled-up folder structure.
|
svelte/no-unnecessary-reactive-curlies rulesvelte/no-extra-reactive-curlies rule
Hmm. I don't know how to fix it. I think we giving esbuild the correct absolute path. |
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Also tightened up matching based on feedback
Per conversation with @ota-meshi in the PR
3d9ebd6 to
26bc92d
Compare
ota-meshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you very much
Porting over a simple rule from https://github.com/tivac/eslint-plugin-svelte/ as per the conversation in #198
I haven't been able to test that the documentation looks right,
yarn svelte-kitis doing some funny path stuff on my windows machine. 🤷🏻♂️