Generalized no-goto-without-base into no-navigation-without-base#900
Merged
baseballyama merged 12 commits intosveltejs:mainfrom Dec 30, 2024
Merged
Generalized no-goto-without-base into no-navigation-without-base#900baseballyama merged 12 commits intosveltejs:mainfrom
no-goto-without-base into no-navigation-without-base#900baseballyama merged 12 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 9bac02b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marekdedic
force-pushed
the
no-navigation-without-base
branch
10 times, most recently
from
daa932b to
8a9a43d
Compare
ota-meshi
requested changes
Nov 27, 2024
Member
ota-meshi
left a comment
ota-meshi
left a comment
There was a problem hiding this comment.
Wow! Thank you for implementing the useful rule!
packages/eslint-plugin-svelte/src/rules/no-navigation-without-base.ts
Outdated
Show resolved
Hide resolved
marekdedic
force-pushed
the
no-navigation-without-base
branch
2 times, most recently
from
1b9b252 to
4676b96
Compare
Member
|
This PR is looks good, but I made this package ESM. Could you please merge the main branch and fix it by adding |
marekdedic
force-pushed
the
no-navigation-without-base
branch
from
4676b96 to
9ccfe71
Compare
marekdedic
force-pushed
the
no-navigation-without-base
branch
from
9ccfe71 to
add6e9b
Compare
Contributor
Author
|
@ota-meshi Done :) |
baseballyama
approved these changes
Dec 30, 2024
This was referenced Feb 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #891