-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Sveltekit internal paths import suggestions #11607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
I think the better solution is to fix this inside SvelteKit itself and change the imports/exports such that the internal module declarations don't end up in the bundled types. |
Any thoughts on how we could do that? Would love to fix this, it's annoying |
dummdidumm
added a commit
that referenced
this issue
Jan 12, 2024
Takes advantage of the fact that dts-buddy doesn't detect the ambient-private.d.ts module declarations (which arguably is a bit weird and could result in buggy behavior, but we can use it to our advantage here). fixes #11607
6 tasks
Rich-Harris
added a commit
that referenced
this issue
Jan 12, 2024
…11620) * fix: remove internal `__sveltekit/` module declarations from types Takes advantage of the fact that dts-buddy doesn't detect the ambient-private.d.ts module declarations (which arguably is a bit weird and could result in buggy behavior, but we can use it to our advantage here). fixes #11607 * lint * re-export values from internal modules * move files * point dts-buddy at facade .d.ts files * remove some junk we no longer need --------- Co-authored-by: Rich Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using ctrl+space to auto import a variable, sveltekit internal paths are suggested.
e.g.
base
from$app/paths
orbuilding
from$app/environment
Reproduction
Expected behaviour
Hide paths starting with
__sveltekit/
System Info
Which package is the issue about?
svelte-language-server
Additional Information, eg. Screenshots
No response
The text was updated successfully, but these errors were encountered: