Skip to content

fix: Stop warning users that crons don't match paths when they actually do#10074

Merged
Rich-Harris merged 2 commits intomasterfrom
elliott/10071-crons-missing
Jun 1, 2023
Merged

fix: Stop warning users that crons don't match paths when they actually do#10074
Rich-Harris merged 2 commits intomasterfrom
elliott/10071-crons-missing

Conversation

@elliott-with-the-longest-name-on-github
Copy link
Contributor

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github commented May 31, 2023

We were continue-ing an inner loop when we intended to continue an outer loop.

Closes #10071

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: 04fcf8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann added the pkg:adapter-vercel Pertaining to the Vercel adapter label Jun 1, 2023
@benmccann
Copy link
Member

I wonder if we should add a test for validate_vercel_json?

@Rich-Harris Rich-Harris merged commit d3cb91c into master Jun 1, 2023
@Rich-Harris Rich-Harris deleted the elliott/10071-crons-missing branch June 1, 2023 21:25
@github-actions github-actions bot mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:adapter-vercel Pertaining to the Vercel adapter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sveltekit vercel adapter ignores cron jobs

3 participants