feat: server js fallthrough to page if handler doesn't exist#10121
feat: server js fallthrough to page if handler doesn't exist#10121
Conversation
🦋 Changeset detectedLatest commit: a176653 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
Needs to merge master in, master contains some changes which adjusts response after the if/else chain which would no longer apply.
|
|
||
| // If endpoint doesn't have a handler for these methods, fall back to the page | ||
| if ( | ||
| response.status === 405 && |
There was a problem hiding this comment.
did you mean for this to be 405? based on the comment I would have expected 404
There was a problem hiding this comment.
Yeah, I think it's 405. Kit responds with 405 method not allowed when the method handler isn't found.
|
@gtm-nayan it looks like this PR still needs a rebase |
|
Through #11256 the underlying issue of conflicting routes was fixed, and as such this PR is no longer necessary - closing. |
4 participants
closes #10102
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.