breaking: stricter route validation, more correct config resolution#11256
Merged
Rich-Harris merged 4 commits intoversion-2from Dec 11, 2023
Merged
breaking: stricter route validation, more correct config resolution#11256Rich-Harris merged 4 commits intoversion-2from
Rich-Harris merged 4 commits intoversion-2from
Conversation
🦋 Changeset detectedLatest commit: fb8cc47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
dummdidumm
reviewed
Dec 11, 2023
| if (mod.prerender && (mod.POST || mod.PATCH || mod.PUT || mod.DELETE)) { | ||
| if (page?.config && endpoint?.config) { | ||
| for (const key in { ...page.config, ...endpoint.config }) { | ||
| if (JSON.stringify(page.config[key]) !== JSON.stringify(endpoint.config[key])) { |
Member
There was a problem hiding this comment.
Is it guaranteed that the keys of both of these are in the same order? i.e. could it fail because content is the same but in different order?
Member
Author
There was a problem hiding this comment.
Below the top level, yes. I didn't think it was worth adding deep equality checking to handle that case, we're in super niche territory
elliott-with-the-longest-name-on-github
approved these changes
Dec 11, 2023
Contributor
elliott-with-the-longest-name-on-github
left a comment
elliott-with-the-longest-name-on-github
left a comment
There was a problem hiding this comment.
Just one little issue, otherwise looks great!
5 tasks
This was referenced Dec 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #11239 that addresses #11239 (comment)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.