Merged
Conversation
Contributor
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sveltejs/kit-demo/3AHB186gqcGRxrwTR1o6hkgCSGud |
Member
Author
|
This is a little tricky to test without actually releasing new adapter versions and trying to deploy stuff with them, so I'm going to do exactly that |
9 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly just playing around for now, but this is intended to solve the perennial problem of dependencies behaving weirdly, by allowing adapters to determine what gets bundled.
For example,
adapter-nodedoesn't need to bundle anything, but an adapter for a serverless platform might. Right now I'm trying to get esbuild to bundle everything inside the Vercel adapter, but it's possible that this belongs in an adapter util.admin
Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintChangesets
pnpx changesetand following the prompts