chore: remove top level promise await behavior#11176
Conversation
🦋 Changeset detectedLatest commit: 7a17acd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It looks like maybe the generated types don't allow |
|
Having fixed two tests, and seing that it's a bit tough to ergonomically do this, I'm wondering if we should provide the function we used previously as a helper that you can import? |
|
the site deploy failure looks like a real bug, though i'm a bit confused by it |
|
oh it's because the site has a |
|
this LGTM — should it still be draft, or can we merge? |
|
I think we can merge, AFAIK it was in draft Mode because of type failures which I fixed |
benmccann
left a comment
There was a problem hiding this comment.
oh wait. this one needs a changeset still
Closes #10106
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.