breaking: undefined is no longer a valid value for paths.relative

[benmccann]

closes #11073

[changeset-bot]

🦋 Changeset detected

Latest commit: 118b9f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dummdidumm]

Can you create a sibling PR that logs a deprecation warning for this? Then we can merge that one into master, and then this PR can remove that warning in favor of the error

[benmccann]

I don't think we want to log a deprecation warning in SvelteKit 1.0 for this one. It would trigger when the user has not set paths.relative forcing them to set it. Then when they upgrade they'd unset the option. Whereas if they just upgrade without doing anything to that option value that's exactly what we want.

I did just update the docs for this to include what the behavior in 1.0 was though. I think that we'll want to call out differences inline since there are so few differences.

[dummdidumm]

Mhm that's true, nevermind then 👍

[Rich-Harris]

small comments on the inline documentation but otherwise LGTM

[benmccann]

I got the tests passing, but I'm quite unsure as to whether my changes to the tests are valid. Please take a look at the changes I made to the test @Rich-Harris and make sure I'm not doing something terribly wrong