Skip to content

breaking: generate plaintext 404.html for Cloudflare Pages, instead of SPA-style fallback #11596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 12, 2024
Merged

breaking: generate plaintext 404.html for Cloudflare Pages, instead of SPA-style fallback #11596

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
780a7ec
breaking: generate plaintext 404.html for Cloudflare Pages, instead o…
Rich-Harris Jan 10, 2024
d8fb28a
oops
Rich-Harris Jan 10, 2024
064d41d
fffffuuuuu
Rich-Harris Jan 10, 2024
8802c07
provide plaintext/spa option
Rich-Harris Jan 11, 2024
97aaa63
Update packages/adapter-cloudflare/index.d.ts
Rich-Harris Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gold-rocks-compare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-cloudflare': major
---

breaking: generate plaintext 404.html instead of SPA-style fallback page
6 changes: 4 additions & 2 deletions packages/adapter-cloudflare/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ export default function (options = {}) {

builder.rimraf(dest);
builder.rimraf(tmp);

builder.mkdirp(dest);
builder.mkdirp(tmp);

// generate 404.html first which can then be overridden by prerendering, if the user defined such a page
await builder.generateFallback(path.join(dest, '404.html'));
// generate plaintext 404.html first which can then be overridden by prerendering, if the user defined such a page
writeFileSync(`${dest}/404.html`, 'Not Found');

const dest_dir = `${dest}${builder.config.kit.paths.base}`;
const written_files = builder.writeClient(dest_dir);
Expand Down