feat: added options to Navigation

[GauBen]

Attempt to implement the feature suggested in #11585

[changeset-bot]

🦋 Changeset detected

Latest commit: 4d73d91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[GauBen]

Not sure I did everything right but I gave it a shot

[Rich-Harris]

Thank you! This is an excellent PR and a really nice feature. Only change I might suggest is making Navigation a discriminated union such that options is always defined for goto and link navigations but otherwise undefined:

I had a crack at implementing it locally but must have borked it up, so I haven't pushed it. (@dummdidumm may have a view on the best way to implement it.) But what do you think?

[GauBen]

That would make perfect sense, let's try that

[GauBen]

It's not as simple as it seems as some navigations of type link might be external:
https://github.com/GauBen/kit/blob/4d73d916a364b9784c75156a59fec328561386d3/packages/kit/src/runtime/client/client.js#L2017

Also, <form> elements might have data-sveltekit attributes

As with elements, you can set the data-sveltekit-reload, data-sveltekit-replacestate, data-sveltekit-keepfocus and data-sveltekit-noscroll attributes on the

to control the router's behaviour.

We might want to split between InternalNavigation and ExternalNavigation rather than discriminate on type

[GauBen]

I won't go further on this, closing to declutter the PR queue