feat: add unit suffix support for BODY_SIZE_LIMIT#11680
Merged
benmccann merged 4 commits intosveltejs:mainfrom Jun 19, 2024
Merged
feat: add unit suffix support for BODY_SIZE_LIMIT#11680benmccann merged 4 commits intosveltejs:mainfrom
BODY_SIZE_LIMIT#11680benmccann merged 4 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: f0f628b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
BODY_SIZE_LIMIT
benmccann
reviewed
Jun 19, 2024
benmccann
approved these changes
Jun 19, 2024
Merged
Contributor
Member
|
thanks. I fixed the bad merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds unit suffixes support to the adapter-node
BODY_SIZE_LIMITenvironment variable.Currently, achieving large byte values is only achievable with the exact byte value, and using exponents (like
1e6to be parsed by Number) results in a byte value in base 10.Nginx and Cloudflare both use base 2 for byte calculations (1024 based):
Nginx (source code): https://hg.nginx.org/nginx/file/default/src/core/ngx_parse.c
Cloudflare (forum question): https://community.cloudflare.com/t/is-max-upload-size-mb-1024-or-1000/239102
Adding unit suffixes to the byte values will make it easier to write and comprehend large byte values, as they can be written such as
100Minstead of104857600Nginx also supports the size units
KandM(https://nginx.org/en/docs/syntax.html) so it would be relevant for Sveltekit to support these units as wellPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits