Skip to content

fix: add warning for form action responses lost without SSR#12063

Merged
teemingc merged 7 commits intosveltejs:mainfrom
mastermakrela:main
Oct 14, 2024
Merged

fix: add warning for form action responses lost without SSR#12063
teemingc merged 7 commits intosveltejs:mainfrom
mastermakrela:main

Conversation

@mastermakrela
Copy link
Contributor

@mastermakrela mastermakrela commented Mar 31, 2024

Fixes #11757.

As described in #11757, when SSR is disabled the values / errors returned from form actions get lost, because the CSR shell is always empty.

This behaviour is correct but can be confusing, if one forgets use:enhance on the form (been there, done that).

As proposed in #11757 (comment), I've added warnings that explain why the desired behaviour didn't occur and how to fix it.

I'm also not sure if such warning needs a test, if yes, I'll try to add it. :)


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2024

🦋 Changeset detected

Latest commit: 83388f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc changed the title Add warning for form action responses lost without SSR fix: add warning for form action responses lost without SSR May 16, 2024
@teemingc teemingc added the forms Stuff relating to forms and form actions label May 16, 2024
@teemingc teemingc merged commit 96642d2 into sveltejs:main Oct 14, 2024
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forms Stuff relating to forms and form actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error swallowed in form action when page has SSR disabled

3 participants