fix: add warning for form action responses lost without SSR#12063
Merged
teemingc merged 7 commits intosveltejs:mainfrom Oct 14, 2024
Merged
fix: add warning for form action responses lost without SSR#12063teemingc merged 7 commits intosveltejs:mainfrom
teemingc merged 7 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 83388f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
reviewed
Oct 11, 2024
teemingc
reviewed
Oct 11, 2024
teemingc
reviewed
Oct 11, 2024
teemingc
reviewed
Oct 11, 2024
dummdidumm
approved these changes
Oct 11, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11757.
As described in #11757, when SSR is disabled the values / errors returned from form actions get lost, because the CSR shell is always empty.
This behaviour is correct but can be confusing, if one forgets
use:enhanceon the form (been there, done that).As proposed in #11757 (comment), I've added warnings that explain why the desired behaviour didn't occur and how to fix it.
I'm also not sure if such warning needs a test, if yes, I'll try to add it. :)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits