fix: add workerd condition to worker build#12069
Merged
teemingc merged 4 commits intosveltejs:mainfrom Apr 3, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 26b4628 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
benmccann
reviewed
Apr 2, 2024
benmccann
reviewed
Apr 2, 2024
Member
|
okay, it looks like |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
teemingc
reviewed
Apr 3, 2024
teemingc
approved these changes
Apr 3, 2024
Member
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was wrestling with an issue for one of our users as we couldn't get the Cloudflare build to bundle correctly. I noticed the conditions SvelteKit uses for bundling the Cloudflare Worker file was
['worker', 'browser']. We hadworkerdwhich was the documented condition that Wrangler uses. I thought this might be a better first condition thenworker.browseris a safe condition to include for the worker bundle. Browser code likewindowwill throw and it's usually a compile-time checkif (__BROWSER__) window.... Might be better to resort to things likeserver/node/default? We bundle our package withbrowserand thendefaultfor server files. Not sure what the standard here is, don't think one exists unfortunately or I haven't seen it.Thanks!
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits