fix: ensure generated tsconfig paths start with ./ if aliasing to ./svelte-kit#12220
Merged
fix: ensure generated tsconfig paths start with ./ if aliasing to ./svelte-kit#12220
./ if aliasing to ./svelte-kit#12220Conversation
🦋 Changeset detectedLatest commit: 98288a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
./ if aliasing to ./svelte-kit
benmccann
reviewed
May 16, 2024
benmccann
reviewed
May 16, 2024
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
benmccann
approved these changes
May 16, 2024
| "@sveltejs/kit": patch | ||
| --- | ||
|
|
||
| fix: correctly handle aliases to files in the `.svelte-kit` directory |
Member
There was a problem hiding this comment.
actually, maybe it'd be more accurate or comprehensive to say:
Suggested change
| fix: correctly handle aliases to files in the `.svelte-kit` directory | |
| fix: correctly handle aliases to files in hidden directories |
Member
Author
There was a problem hiding this comment.
I'm not sure that's right. The only issue was that aliases to files in .svelte-kit did not start with a leading ./ so tsconfig considered them to be non-relative paths and complained e.g. "types/routes/src/*"
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #12169
Appends a
"./"to the generated tsconfig path so that aliases to files in.svelte-kit/...don't cause the user's tsconfig.json to complain about non-relative paths.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits