fix: suppress console spam for chrome devtools requests #13830
Conversation
🦋 Changeset detectedLatest commit: fd828d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -573,6 +573,13 @@ export async function respond(request, options, manifest, state) { | |||
| // if this request came direct from the user, rather than | |||
| // via our own `fetch`, render a 404 page | |||
| if (state.depth === 0) { | |||
| // In local development, Chrome requests this file for its 'automatic workspace folders' feature, | |||
| // causing console spam. TODO should we instead respond with some actual data? | |||
There was a problem hiding this comment.
could always delegate to https://github.com/ChromeDevTools/vite-plugin-devtools-json
There was a problem hiding this comment.
I sent vitejs/awesome-vite#1030 to make it easier to find again if we need to track it down
Co-authored-by: Ben McCann <[email protected]>
|
I just tried adding the plugin and it is pretty useful. The plugin is extremely straightforward. I'm tempted to integrate it. Is there any real reason not to? |
|
Maybe I should give it a try. What did you find useful about it? |
|
Ah, I hadn't checked Discord yet. Will take a look there |
Closes #13743. As an alternative, we might consider responding with some data (which is the intended behaviour), but I'm not familiar with it and we would need to think through any security implications or whatever
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits