Skip to content

fix: resolve assets.directory path from wrangler config #14036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2025

Conversation

GauBen
Copy link
Contributor

@GauBen GauBen commented Jul 23, 2025

Hi!

This PR fixes a bug in the current version of the Cloudflare adapter: it always assumes that the wrangler.json config file is in the same directory as the .svelte-kit directory.

With this fix, the wrangler.json can be placed anywhere (parent and children directories work)


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jul 23, 2025

🦋 Changeset detected

Latest commit: 5a02a40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Ben McCann <[email protected]>
@svelte-docs-bot
Copy link

@eltigerchino eltigerchino changed the title fix(adapter-cloudflare): resolve paths from wrangler config fix: resolve paths from wrangler config Jul 31, 2025
@eltigerchino eltigerchino changed the title fix: resolve paths from wrangler config fix: resolve assets.directory path from wrangler config Jul 31, 2025
Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eltigerchino eltigerchino merged commit a6f7259 into sveltejs:main Jul 31, 2025
34 of 35 checks passed
@github-actions github-actions bot mentioned this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants