Skip to content

Conversation

@Rich-Harris
Copy link
Member

Fixes #808. Will need a release of vite-plugin-svelte with this change before the tests will pass.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@dominikg
Copy link
Member

sveltejs/vite-plugin-svelte#41 has been released in @sveltejs/[email protected]

@Rich-Harris
Copy link
Member Author

excellent, thanks so much!

@Conduitry
Copy link
Member

Was switching the Vite plugin from a prod to a dev dep intended? How are you deciding which things are which kind of dependency?

@Rich-Harris
Copy link
Member Author

That wasn't intentional — reverted. The basic thinking is that if something is bundleable, it gets bundled, since that way Kit is faster to install. But I'm not sure if it's been applied particularly rigorously or if we should even be thinking that way

@benmccann
Copy link
Member

I don't suppose it's possible that AMP support will no longer be needed now that Google is showing non-AMP pages in the search carousel? 😁 https://www.lafoo.com/the-end-of-amp/

@Rich-Harris Rich-Harris merged commit cfd6c3c into master May 11, 2021
@Rich-Harris Rich-Harris deleted the gh-808 branch May 11, 2021 15:14
@Rich-Harris
Copy link
Member Author

maybe for SvelteKit 2. time will tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use rendered rather than emitted CSS in AMP mode

5 participants