Skip to content

fix: conditionally access builder properties that only exist on the latest SvelteKit#14233

Merged
teemingc merged 4 commits intomainfrom
fix-kit-adapter-builder-support
Aug 16, 2025
Merged

fix: conditionally access builder properties that only exist on the latest SvelteKit#14233
teemingc merged 4 commits intomainfrom
fix-kit-adapter-builder-support

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Aug 16, 2025

fixes #14232

We overlooked that some people might update their adapters but not SvelteKit, so those new instrumentation builder methods wouldn't exist and they get null pointer errors. Simon usually catches these but I always forget.

This PR fixes that and future-proofs it by making new builder properties possibly undefined so that we get type errors and can catch these earlier.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
    • does type checking count?

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
  • no changeset for the static and auto adapter since those are just internal type changes

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2025

🦋 Changeset detected

Latest commit: 0aa696c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-vercel Patch
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution that relieves me from thinking about/catching this 😁👍

@dummdidumm
Copy link
Member

Mhm still some type errors but once you fixed them you can hit merge (am AFK right now)

@teemingc
Copy link
Member Author

Mhm still some type errors but once you fixed them you can hit merge (am AFK right now)

Should be fixed now.

@teemingc teemingc merged commit 758ec17 into main Aug 16, 2025
21 checks passed
@teemingc teemingc deleted the fix-kit-adapter-builder-support branch August 16, 2025 11:16
@github-actions github-actions bot mentioned this pull request Aug 15, 2025
Copilot AI pushed a commit to Stadly/kit that referenced this pull request Mar 6, 2026
…atest SvelteKit (sveltejs#14233)

* add null checks for builder properties that may not exist

* changeset

* format

* fix type errors where we're sure it won't be null or undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@sveltejs/adapter-vercel v5.9.0 causes build failure

2 participants