fix: conditionally access builder properties that only exist on the latest SvelteKit#14233
Merged
fix: conditionally access builder properties that only exist on the latest SvelteKit#14233
Conversation
🦋 Changeset detectedLatest commit: 0aa696c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
Aug 16, 2025
Member
dummdidumm
left a comment
There was a problem hiding this comment.
Great solution that relieves me from thinking about/catching this 😁👍
Member
|
Mhm still some type errors but once you fixed them you can hit merge (am AFK right now) |
Member
Author
Should be fixed now. |
Merged
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
…atest SvelteKit (sveltejs#14233) * add null checks for builder properties that may not exist * changeset * format * fix type errors where we're sure it won't be null or undefined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14232
We overlooked that some people might update their adapters but not SvelteKit, so those new instrumentation builder methods wouldn't exist and they get null pointer errors. Simon usually catches these but I always forget.
This PR fixes that and future-proofs it by making new builder properties possibly undefined so that we get type errors and can catch these earlier.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits