Skip to content

Conversation

@th0rgall
Copy link
Contributor

@th0rgall th0rgall commented Sep 29, 2025

closes #14471

My main edit here is in the adapter-static (SSG) docs, where I believe a warning should be placed to not disable SSR when trying to achieve SSG.

I also added a few warnings and links in the glossary and page options docs to guide people to the right information when they are researching SSG in SvelteKit.

These changes don't solve the situation that it's conceptually counter-intuitive (to me) that SSG/prerendering requires "SSR", but it tries to help developers to not making unintended mistakes based on wrong assumptions.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2025

⚠️ No Changeset found

Latest commit: 007a374

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@teemingc teemingc added the documentation Improvements or additions to documentation label Oct 8, 2025
@svelte-docs-bot
Copy link

@teemingc teemingc changed the title docs: clarify that SSR is required for SSG with content (#14471) docs: clarify that SSR is required for SSG with content Feb 5, 2026
Copy link
Member

@teemingc teemingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I've made a few suggestions to integrate the information we want to convey into the existing paragraphs rather than being tacked on at the end.

Copy link
Contributor Author

@th0rgall th0rgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing this & making it more concise!

Copy link
Member

@teemingc teemingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

teemingc and others added 2 commits February 7, 2026 13:57
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
@teemingc teemingc merged commit 3cbaac2 into sveltejs:main Feb 7, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: clarify that ssr = true is required for prerendering in adapter-static

2 participants