-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: clarify that SSR is required for SSG with content #14560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I've made a few suggestions to integrate the information we want to convey into the existing paragraphs rather than being tacked on at the end.
Co-authored-by: Tee Ming <[email protected]>
Co-authored-by: Tee Ming <[email protected]>
Co-authored-by: Tee Ming <[email protected]>
Co-authored-by: Tee Ming <[email protected]>
Co-authored-by: Tee Ming <[email protected]>
Co-authored-by: Tee Ming <[email protected]>
th0rgall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing this & making it more concise!
teemingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
closes #14471
My main edit here is in the adapter-static (SSG) docs, where I believe a warning should be placed to not disable SSR when trying to achieve SSG.
I also added a few warnings and links in the glossary and page options docs to guide people to the right information when they are researching SSG in SvelteKit.
These changes don't solve the situation that it's conceptually counter-intuitive (to me) that SSG/prerendering requires "SSR", but it tries to help developers to not making unintended mistakes based on wrong assumptions.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits