Fix adapter-netlify query params splitting (#1466)#1467
Merged
benmccann merged 3 commits intosveltejs:masterfrom May 18, 2021
Merged
Fix adapter-netlify query params splitting (#1466)#1467benmccann merged 3 commits intosveltejs:masterfrom
benmccann merged 3 commits intosveltejs:masterfrom
Conversation
benmccann
reviewed
May 17, 2021
Member
benmccann
left a comment
There was a problem hiding this comment.
lgtm except that you're bumping the version number more than we normally do
Member
|
It looks to me like kit/packages/adapter-begin/src/index.js Line 10 in 06380d7 Would you mind updating that one as well? |
Contributor
Author
Sure thing, I updated that one as well. |
benmccann
approved these changes
May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of manually recreating the query parameters object from Netlify Functions'
queryStringParametersobject it is directly using therawQueryobject to create theURLSearchParams.Fixes #1466
Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintChangesets
pnpx changesetand following the prompts