Skip to content

Conversation

@jycouet
Copy link
Contributor

@jycouet jycouet commented Nov 17, 2025

Fixes sveltejs/cli#783

transform .ts extensions to .js in import/export statements when using allowImportingTsExtensions


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2025

🦋 Changeset detected

Latest commit: f2b9d10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jycouet jycouet changed the title add a failing test svelte-package & allowImportingTsExtensions Nov 17, 2025
@benmccann benmccann added the pkg:svelte-package Issues related to svelte-package label Nov 17, 2025
@jycouet jycouet marked this pull request as ready for review November 18, 2025 07:46
@dummdidumm
Copy link
Member

dummdidumm commented Nov 20, 2025

Thank you! Two suggestions:

  • In utils.js#resolve_aliases we already have battle-tested regexes for replacing paths. We should extract that to reuse it here
  • After doing that I think we can replace the e2e test with a unit test (check that the method replaces .ts->.js) as that one will run a lot faster (the e2e tests are really slow)

Update: With #14673 merged we also gotta take this into account. Will update this PR shortly

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm changed the title svelte-package & allowImportingTsExtensions fix: rewrite .ts to .js when rewriteRelativeImportExtensions enabled (svelte-package) Nov 20, 2025
@dummdidumm dummdidumm merged commit fa32cc0 into sveltejs:main Nov 20, 2025
19 of 21 checks passed
@github-actions github-actions bot mentioned this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:svelte-package Issues related to svelte-package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot load .ts file in the package template output

3 participants