-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: rewrite .ts to .js when rewriteRelativeImportExtensions enabled (svelte-package) #14936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rewrite .ts to .js when rewriteRelativeImportExtensions enabled (svelte-package) #14936
Conversation
🦋 Changeset detectedLatest commit: f2b9d10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
svelte-package & allowImportingTsExtensions
|
Thank you! Two suggestions:
Update: With #14673 merged we also gotta take this into account. Will update this PR shortly |
…ImportingTsExtensions' into pr/jycouet/14936
dummdidumm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
svelte-package & allowImportingTsExtensions
Fixes sveltejs/cli#783
transform
.tsextensions to.jsin import/export statements when usingallowImportingTsExtensionsPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits