Skip to content

Conversation

@BastiDood
Copy link
Contributor

Closes #15022.

As a follow-up to #14993, I was able to reliably reproduce the regression. Prior to merging the commit, the emitted output looks like this:

// Actual
import './server\instrumentation.server.js';
// Expected
import './server/instrumentation.server.js';

This PR introduces the regression test that checks against this case specifically.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025

⚠️ No Changeset found

Latest commit: eb335a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@BastiDood BastiDood changed the title test(kit): add regression for the posixied instrumentation file test(kit): add regression test for the posixied instrumentation file Dec 3, 2025
@BastiDood BastiDood force-pushed the test/instrumentation-file branch from 92a249e to fe48d82 Compare December 3, 2025 21:08
@BastiDood
Copy link
Contributor Author

The test failure is likely flaky and unrelated. I doubt that the new test introduced a regression to the client.test.js script. Should be safe to retry?

1 failed
  [webkit-build] › test/cross-platform/client.test.js:962:2 › Routing › responds to <button formtarget="_blank" submission with new tab 
1 flaky
  [webkit-build] › test/cross-platform/client.test.js:948:2 › Routing › responds to <form target="_blank"> submission with new tab 

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github merged commit cd6837c into sveltejs:main Dec 4, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing tests for instrumentation.server.js for Windows

2 participants