feat(vite): allow setting custom cwd path#15188
feat(vite): allow setting custom cwd path#15188polvallverdu wants to merge 1 commit intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 101ac8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Please see #12420 (comment) and #12410 (comment). I'm not sure this is necessary |
|
I also think we should lean on monorepo tools for this if possible -- if you have a use case that doesn't work with |
Main issue here is that, even though vitest correctly sets the root directory, the sveltekit plugin overrides it to process.cwd(), which is incorrect, and breaks monorepo compatibility. Maybe a better solution would be the sveltekit plugin to rely on the root from vitest (or vite) rather than process.cwd(), but that might be a bigger breaking change.
In CI a single |
SvelteKit has to tell Vite where the root is. There's no way to do it in the other direction |
…ory (#15469) closes #11356 closes #12140 closes #15188 This PR standardises the use of `process.cwd()` to prefer the Vite config `root` setting when available [similar to VPS](https://github.com/sveltejs/vite-plugin-svelte/blob/main/packages/vite-plugin-svelte/src/utils/options.js#L354-L356). This helps us resolve paths correctly before reading files or generating tsconfig paths. It eases lots of monorepo tooling usage, particularly Vitest workspaces. This also allows us to use the Vitest IDE extension to run unit tests (which didn't work before because of the aforementioned issues). We _could_ backport these changes to v2 but it's a bit easier to base it on v3 which already makes use of `import.meta.dirname` in many places thanks to #15434 I've only made changes to `kit` itself for now, so other packages still default to `process.cwd()` but those are probably less problematic since they won't run for Vitest tests --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
closes #13748
I have a monorepo with a package being a sveltekit app. I do unit testing, but it was completely failing when running vitest from the monorepo due to aliases not working, and mainly, the vite sveltekit plugin not finding the svelte.config.js file.
I fixed it with a patch allowing to override the cwd (solution proposed on the linked issue), and setting the cwd like this:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits