-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: correct typo in NavigationEnter type #15260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix spelling of "occured" to "occurred" in the JSDoc comment for NavigationEnter.event property.
|
|
The CI failure is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a documentation PR and does not need a changeset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one might. It fixes the JSDoc that shows up in the IDE too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't change the functionality of the library in any way so I'm inclined not to create a release for it
teemingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix spelling of "occured" to "occurred" in the JSDoc comment for the
NavigationEnter.eventproperty in both the source type definition and the generated types file.