Skip to content

fix: ignore third-party monkeypatches in pushState/replaceState warning #15267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankFMY wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

fix: ignore third-party monkeypatches in pushState/replaceState warning #15267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-pushstate-warning-monkeypatch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: ignore third-party monkeypatches in `pushState`/`replaceState` warning detection
3 changes: 3 additions & 0 deletions packages/kit/src/runtime/client/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ if (DEV && BROWSER) {
if (!stack) return;
if (!stack[0].includes('https:') && !stack[0].includes('http:')) stack = stack.slice(1); // Chrome includes the error message in the stack
stack = stack.slice(2); // remove `warn` and the place where `warn` was called
// Filter out frames from third-party libraries that monkeypatch history methods (e.g. Sentry),
// since their presence in the stack doesn't mean the call originated from outside SvelteKit
stack = stack.filter((frame) => !frame.includes('node_modules'));
// Can be falsy if was called directly from an anonymous function
if (stack[0]?.includes(current_module_url)) return;

Expand Down
Loading