fix: suppress inner content warning when children prop is forwarded #15269
+49
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a +layout.svelte passes children to a child component via
shorthand ({children}) or explicit prop (children={children}),
the "inner content will not be rendered" warning no longer fires.
Closes sveltejs#13504
🦋 Changeset detectedLatest commit: acb0b5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
requested changes
Feb 6, 2026
Comment on lines
157
to
169
| // Recreate the markup children detection logic for testing (mirrors warning_preprocessor in vite/index.js) | ||
| /** | ||
| * @param {string} content | ||
| * @returns {boolean} | ||
| */ | ||
| function has_children(content) { | ||
| return ( | ||
| content.includes('<slot') || | ||
| content.includes('{@render') || | ||
| content.includes('{children}') || | ||
| content.includes('children={') | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
No, this is a very bad idea, this will drift. If we want tests for this then the logic in vite/index.js should be extracted out into a function in utils.js and be imported/tested here
FrankFMY
commented
Feb 6, 2026
Contributor
Author
FrankFMY
left a comment
FrankFMY
left a comment
There was a problem hiding this comment.
Done — extracted has_children into utils.js and imported it in both index.js and the test file.
dummdidumm
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13504
When a
+layout.svelteforwardschildrento a child component instead of rendering it directly with{@render children()}, the warning "<slot />or{@render ...}tag missing — inner content will not be rendered`" fires as a false positive.This PR suppresses the warning when
childrenis passed to a child component via:<Layout {children} /><Layout children={children} />As suggested by @elliott-with-the-longest-name-on-github in the issue discussion.
Changes
packages/kit/src/exports/vite/index.js— Extendhas_childrencheck to detect{children}andchildren={patterns in markuppackages/kit/src/exports/vite/static_analysis/utils.spec.js— Add unit tests for children forwarding detectionTest plan
pnpm -F @sveltejs/kit test:unit— 424 tests passedpnpm run format— clean