docs: clarify query.batch code example #15289
Conversation
Give more specific variable names for easier understanding Closes #15278
|
|
|
||
| export const getWeather = query.batch(v.string(), async (cities) => { | ||
| export const getWeather = query.batch(v.string(), async (cityIds) => { | ||
| const weather = await db.sql` |
There was a problem hiding this comment.
Leaving a same comment here. Since this returns an array, wouldn't it be better to rename it to weathers?
There was a problem hiding this comment.
Weathers is not a thing, there's no plural to weather. I think it's clear enough as is.
There was a problem hiding this comment.
Weathers does exist as a plural form. Here are some dictionary results:
- https://www.britannica.com/dictionary/weather
- https://dic.daum.net/word/view.do?wordid=ekw000184029&supid=eku001645889
It would be much more intuitive to grasp that it's an array:
const posts = await db.sql``;
const [post] = await db.sql``;Thought are other .map() usages that use a singular form.
// not scripts
hashes.script.map((hash) => `'${hash}'`).join(' ')
3 participants
Give more specific variable names for easier understanding
Closes #15278