-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: remove unnecessary path validation which breaks fetch with custom path base #15291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
goulinkh
wants to merge
9
commits into
sveltejs:main
Choose a base branch
from
goulinkh:fix-custom-base-fetch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+107
−3
Open
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
db812b3
fix: resolve `fetch` issue with same host URLs differing from `paths.…
goulinkh eb708f3
fix: enhance fetch and respond logic for base path handling
goulinkh 7a1700b
refactor: improve testing for link outside base path
goulinkh 8d450d9
fix: ensure correct base path handling in fetch logic by reusing deco…
goulinkh 295b2b6
fix: add more test cases and include additional check for base path f…
goulinkh 5ec2276
Merge branch 'main' into fix-custom-base-fetch
goulinkh 038ec8a
fix: reduce timeout duration in request-abort test
goulinkh 1daafbd
refactor: improve testing
goulinkh 208b2ab
fix: update changeset and improve test assertions
goulinkh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@sveltejs/kit': major | ||
| --- | ||
|
|
||
| fix: `fetch` not working when URL is same host but different than `paths.base` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
packages/kit/test/apps/options/source/pages/routing/link-outside-base/+page.server.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| export async function load({ fetch }) { | ||
| const response = await fetch('/not-base-path/'); | ||
| return { | ||
| fetchUrl: response.url | ||
| }; | ||
| } |
6 changes: 6 additions & 0 deletions
6
packages/kit/test/apps/options/source/pages/routing/link-outside-base/+page.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <script> | ||
| /** @type {{ data: { fetchUrl: string } }} */ | ||
goulinkh marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| const { data } = $props(); | ||
| </script> | ||
|
|
||
| <p data-testid="fetch-url">{data.fetchUrl}</p> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should only be major for a breaking change (of a previously valid behaviour?). However, I don't think anyone would purposely try to have the load fetch trigger the SvelteKit server response if it's requesting an entirely different path