Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eighty-paws-love.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': major
---

breaking: remove `createEntries` from the `Builder` object passed to adapter functions
52 changes: 0 additions & 52 deletions packages/kit/src/core/adapt/builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,58 +103,6 @@ export function create_builder({
);
},

async createEntries(fn) {
const seen = new Set();

for (let i = 0; i < route_data.length; i += 1) {
const route = route_data[i];
if (prerender_map.get(route.id) === true) continue;
const { id, filter, complete } = fn(routes[i]);

if (seen.has(id)) continue;
seen.add(id);

const group = [route];

// figure out which lower priority routes should be considered fallbacks
for (let j = i + 1; j < route_data.length; j += 1) {
if (prerender_map.get(routes[j].id) === true) continue;
if (filter(routes[j])) {
group.push(route_data[j]);
}
}

const filtered = new Set(group);

// heuristic: if /foo/[bar] is included, /foo/[bar].json should
// also be included, since the page likely needs the endpoint
// TODO is this still necessary, given the new way of doing things?
filtered.forEach((route) => {
if (route.page) {
const endpoint = route_data.find((candidate) => candidate.id === route.id + '.json');

if (endpoint) {
filtered.add(endpoint);
}
}
});

if (filtered.size > 0) {
await complete({
generateManifest: ({ relativePath }) =>
generate_manifest({
build_data,
prerendered: [],
relative_path: relativePath,
routes: Array.from(filtered),
remotes,
root: vite_config.root
})
});
}
}
},

findServerAssets(route_data) {
return find_server_assets(
build_data,
Expand Down
5 changes: 2 additions & 3 deletions packages/kit/src/exports/public.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,12 @@ export interface Builder {
/** An array of all routes (including prerendered) */
routes: RouteDefinition[];

// TODO 3.0 remove this method
/**
* Create separate functions that map to one or more routes of your app.
* @param fn A function that groups a set of routes into an entry point
* @deprecated Use `builder.routes` instead
* @deprecated removed in 3.0. Use `builder.routes` instead
*/
createEntries: (fn: (route: RouteDefinition) => AdapterEntry) => Promise<void>;
createEntries?: (fn: (route: RouteDefinition) => AdapterEntry) => Promise<void>;

/**
* Find all the assets imported by server files belonging to `routes`
Expand Down
5 changes: 2 additions & 3 deletions packages/kit/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,12 @@ declare module '@sveltejs/kit' {
/** An array of all routes (including prerendered) */
routes: RouteDefinition[];

// TODO 3.0 remove this method
/**
* Create separate functions that map to one or more routes of your app.
* @param fn A function that groups a set of routes into an entry point
* @deprecated Use `builder.routes` instead
* @deprecated removed in 3.0. Use `builder.routes` instead
*/
createEntries: (fn: (route: RouteDefinition) => AdapterEntry) => Promise<void>;
createEntries?: (fn: (route: RouteDefinition) => AdapterEntry) => Promise<void>;

/**
* Find all the assets imported by server files belonging to `routes`
Expand Down
Loading