Allow sirv to looks for precompiled gzip and brotli files by default#1672
Merged
benmccann merged 2 commits intosveltejs:masterfrom Jun 11, 2021
realadvisor:master
Merged
Allow sirv to looks for precompiled gzip and brotli files by default#1672benmccann merged 2 commits intosveltejs:masterfrom realadvisor:master
benmccann merged 2 commits intosveltejs:masterfrom
realadvisor:master
Conversation
lukeed
approved these changes
Jun 11, 2021
Member
lukeed
left a comment
There was a problem hiding this comment.
Technically this means sirv is doing more checks on every request (< 1ms) but that's totally fine 😆 If this part of the app were ever to be exposed to the config layer, it'd be a good thing to expose (with some forced SK overrides)
Member
|
@istarkov can you add a patch changeset so that this PR can be merged and released? ( |
Member
|
I'm curious if there's any Vite or Rollup plugin that you could use rather than a custom script |
Contributor
Author
Yes some plugins exists https://www.npmjs.com/package/rollup-plugin-brotli and same for gzip, |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not change anyting for users who doesnt use brotli or gzip precompiled asset files. But brotli gives real advantages over gzip in compression size.
In absense of sirv config, probably it can be a good default.
For compressing we use following script.