[fix] adapter-netlify: support for multivalue headers#1906
Merged
benmccann merged 5 commits intosveltejs:masterfrom Jul 14, 2021
Merged
[fix] adapter-netlify: support for multivalue headers#1906benmccann merged 5 commits intosveltejs:masterfrom
benmccann merged 5 commits intosveltejs:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 29c9c3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Jul 14, 2021
Member
|
This looks pretty good to me. The one thing I wonder though is if it's the case that |
Member
|
thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0Fixes #1741 by moving
set-cookietomultiValueHeaderswhenever it sets more than one cookie.