Skip to content

[chore] typecheck example#2019

Merged
benmccann merged 2 commits intomasterfrom
example-typing
Jul 27, 2021
Merged

[chore] typecheck example#2019
benmccann merged 2 commits intomasterfrom
example-typing

Conversation

@benmccann
Copy link
Member

@benmccann benmccann commented Jul 26, 2021

This fixes some bugs. It's not actually enforced yet because I think it was trying to look at the unpackaged types from the monorepo, which was causing some issues. Maybe someone can figure that out

FYI @ignatiusmb, another TypeScript one 😄

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 16b7b1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ignatiusmb
ignatiusmb approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@ignatiusmb ignatiusmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typing looks good, minor nit on spacings between code

@benmccann
Copy link
Member Author

benmccann commented Jul 26, 2021

minor nit on spacings between code

I don't see any other comments. Maybe you forgot to hit send on them?

ignatiusmb
ignatiusmb reviewed Jul 27, 2021
View reviewed changes
Copy link
Member

@ignatiusmb ignatiusmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was pretty late at night yesterday, here you go :)

@benmccann benmccann merged commit f732275 into master Jul 27, 2021
@benmccann benmccann deleted the example-typing branch July 27, 2021 19:09
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jul 31, 2021
@sidharthv96
Merge branch 'master' of https://github.com/sveltejs/kit into fix/bas…
d1179e2 
…ePath

* 'master' of https://github.com/sveltejs/kit: (85 commits)
  [chore] minor simplification of `parse_body` (sveltejs#2043)
  Version Packages (next) (sveltejs#2026)
  [chore] deduplicate config types (sveltejs#2030)
  [chore] remove invalid css declaration (sveltejs#2038)
  [fix] correctly pass Vite options in preview mode (sveltejs#2036)
  [feat] Ignore adapter build files (sveltejs#1924)
  [chore] Upgrade Rollup
  Don't check external links on prerender (sveltejs#1679)
  Version Packages (next) (sveltejs#2017)
  [chore] convert remaining type aliases (sveltejs#2018)
  [feat] explicitly set compilerOptions.hydratable to config.kit.hydrate (sveltejs#2024)
  [feat] More powerful and configurable rendering options (sveltejs#2008)
  [chore] typecheck example (sveltejs#2019)
  Change config `prerender.force` to `prerender.onError` (sveltejs#2007)
  [chore] prefer interfaces to types (sveltejs#2010)
  [docs] minor wording improvement in migration guide (sveltejs#2006)
  [chore] test debugging improvements
  [docs] fix typo (sveltejs#2003)
  [chore] use @ts-expect-error instead of @ts-ignore (sveltejs#1999)
  Version Packages (next) (sveltejs#1996)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ignatiusmb ignatiusmb ignatiusmb approved these changes

Assignees

No one assigned

Labels

examples types / typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benmccann @ignatiusmb