refactor routing logic #211
Conversation
| }; | ||
|
|
||
| branch = await Promise.all( | ||
| [[() => this.layout, () => {}], ...route.parts].map(async ([loader, get_params], i) => { |
There was a problem hiding this comment.
I don't really get what this is doing. Why do we need a loader instead of just accessing this.layout directly? Why is get_params always returning {}?
There was a problem hiding this comment.
Why do we need a
loaderinstead of just accessingthis.layoutdirectly
because route.parts is an array of [loader, get_params] arrays, but the layout component is excluded from the manifest (because it's always present) so needs to be inserted before other components in a consistent way, and this was the quickest way to get it to behave
|
|
||
| const { default: component, preload } = await loader(); | ||
|
|
||
| const params = get_params ? get_params(match) : {}; |
There was a problem hiding this comment.
do we ever have to worry about get_params not being defined here?
There was a problem hiding this comment.
yes. it's only included for page/layout components that have [dynamic] routes
|
A few minor TODOs remaining here and there but I think it makes sense to merge this for now |
This code was confusing the hell out of me. Still lots to do but this should be a lot friendlier. Essentially it adds two singletons,
routerandrenderer—routerselects routes given anhrefand interacts with thehistoryAPI, whilerendereris responsible for rendering a selected route (which includes loading its code and runningpreload).