-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[feat] merge packaging exports #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: dce75bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good addition. I'm split on whether we should do a boolean (that could become a function) or do the enum. If there's more than true/false/function, then definitely the enum, but other than deepMerge
I don't see a valid third option (and maybe merge
should merge deep anyway).
Come to think of it, there can't be a situation where both One awkward thing to this is that users that would like to get their self-defined exports map merged but still have all other exports generated would need to pass an empty object to the config, |
I'm not completely sure I understand. Rereading #1944, there's truth in the OP's post: " if I don't want svelte-kit package to touch my exports I can just do |
What would I do without you and your reviews @dummdidumm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I didn't get to this in hindsight obvious conclusion, too, at first 😄
Resolves #1944
Still not sure if
package.exports.behavior
is a good settings, inputs are welcome. Also note to self, need to add some docs.