Skip to content

[fix] externalize middlewares.js when using adapter-node's entryPoint #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Conduitry merged 2 commits into from
Sep 24, 2021
Merged

[fix] externalize middlewares.js when using adapter-node's entryPoint #2482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ca1b7
[fix] externalize middlewares.js when using adapter-node's entryPoint
Conduitry Sep 23, 2021
d8f380c
add changeset
Conduitry Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mighty-ears-divide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-node': patch
---

[fix] Correctly treat `middlewares.js` as external when using `entryPoint` option
11 changes: 7 additions & 4 deletions packages/adapter-node/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
statSync,
writeFileSync
} from 'fs';
import { join } from 'path';
import { join, resolve } from 'path';
import { pipeline } from 'stream';
import glob from 'tiny-glob';
import { fileURLToPath } from 'url';
Expand Down Expand Up @@ -81,7 +81,6 @@ export default function ({
entryPoints: [entryPoint],
outfile: join(out, 'index.js'),
bundle: true,
external: ['./middlewares.js'], // does not work, eslint does not exclude middlewares from target
format: 'esm',
platform: 'node',
target: 'node12',
Expand All @@ -90,8 +89,12 @@ export default function ({
{
name: 'fix-middlewares-exclude',
setup(build) {
// Match an import called "./middlewares.js" and mark it as external
build.onResolve({ filter: /^\.\/middlewares\.js$/ }, () => ({ external: true }));
// Match an import of "middlewares.js" and mark it as external
build.onResolve({ filter: /\/middlewares\.js$/ }, ({ path, resolveDir }) => {
if (resolve(resolveDir, path) === resolve(out, 'middlewares.js')) {
return { path: './middlewares.js', external: true };
}
});
}
}
]
Expand Down