-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[chore] update vite-plugin-svelte #2626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: df0fc7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We might need to update Svelte core as well for the new |
Waiting for sveltejs/vite-plugin-svelte#202 before it's ready (EDIT: It's ready) |
Hmm, |
Looks like vitejs/vite#5273 may have brought extra types that weren't properly generated |
a4bd795
to
79d54b4
Compare
I haven't had time to figure out a fix, but it seems to be an issue in Vite. I've reverted the commit for now. |
I filed an issue in Vite regarding the types bug: vitejs/vite#5338 |
Fixes #720
May address #2612 if experimental.prebundleSvelteLibraries works. I've tested this in a local production repo and it's working flawlessly.
vite-plugin-svelte
also dropped support for node 12.Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0