Merged
Conversation
🦋 Changeset detectedLatest commit: 9832709 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Dec 1, 2021
packages/kit/test/apps/basics/src/routes/imports/markdown.svelte
Outdated
Show resolved
Hide resolved
Member
|
probably not a bad idea to have a changeset just to be safe. I'd rather err towards mentioning something in the changelog than not |
Contributor
Author
done. |
benmccann
approved these changes
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update dependencies
Notes:
typescript 4.5 is available but updated to ~4.4.4 (4.5 introduces .d.mts files that cause test failures, needs investigation)
esbuild 0.14 available but updated to 0.13.15 (avoid breaking changes)
Major updates for marked and mime in kit package.
No changesets added, do we require them for minor esbuild updates (may affect adapter builds?)
It looks like vite is going to stick with typescript 4.4/esbuild 0.13 for the upcoming 2.7 release and updates them in 2.8 afterwards.
We should do a concerted update to ts 4.5/esbuild 0.14/vite 2.8 once that has happened.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0