[fix] polyfill fetch before running any app code#3400
Merged
Rich-Harris merged 1 commit intosveltejs:masterfrom Jan 19, 2022
Merged
[fix] polyfill fetch before running any app code#3400Rich-Harris merged 1 commit intosveltejs:masterfrom
Rich-Harris merged 1 commit intosveltejs:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 848f2aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 848f2aa 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e6f6927bd42f00079473ff |
bluwy
approved these changes
Jan 19, 2022
Member
|
ah whoops — thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3343
Before this change, referencing
fetchat the top level ofhooks.jswould throwReferenceError: fetch is not definedon platforms without native fetch. This is because we were polyfillingfetchafter importing the compiled app, at which point it was too late. It looks like this was introduced with the adapter overhaul, where we stopped using esbuild'sinjectoption.To fix this, I moved the call to
__fetch_polyfillinside its own module so that it would run before importing the app. I had to give it its own Rollup entry (in the adapters that use Rollup) so that it remained separate and import order was preserved.I tested this locally with the node adapter and it fixed the linked issue. I also locally generated bundles with the Netlify and Vercel adapter and verified that
__fetch_polyfillis called before any app code.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0