Skip to content

[fix] adapter-node ORIGIN runtime environment variable#3448

Merged
Conduitry merged 2 commits intosveltejs:masterfrom
Conduitry:fix-adapter-node-origin
Jan 20, 2022
Merged

[fix] adapter-node ORIGIN runtime environment variable#3448
Conduitry merged 2 commits intosveltejs:masterfrom
Conduitry:fix-adapter-node-origin

Conversation

@Conduitry
Copy link
Member

#3423 was an incomplete fix. The adapter was producing output like const origin = process.env["ORIGIN"] && process.env[process.env["ORIGIN"]]; when we just wanted const origin = process.env["ORIGIN"];. I'd still like another set of eyes on this because I did get it wrong last time.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 8c01f4b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e97c746b13ca0007a80cfa

@Conduitry Conduitry added p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc. pkg:adapter-node labels Jan 20, 2022
@Conduitry Conduitry merged commit e364454 into sveltejs:master Jan 20, 2022
@Conduitry Conduitry deleted the fix-adapter-node-origin branch January 20, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-important SvelteKit cannot be used by a large number of people, basic functionality is missing, etc. pkg:adapter-node

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants