[fix] adapter-node ORIGIN runtime environment variable#3448
Merged
Conduitry merged 2 commits intosveltejs:masterfrom Jan 20, 2022
Merged
[fix] adapter-node ORIGIN runtime environment variable#3448Conduitry merged 2 commits intosveltejs:masterfrom
Conduitry merged 2 commits intosveltejs:masterfrom
Conversation
|
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 8c01f4b 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e97c746b13ca0007a80cfa |
Rich-Harris
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3423 was an incomplete fix. The adapter was producing output like
const origin = process.env["ORIGIN"] && process.env[process.env["ORIGIN"]];when we just wantedconst origin = process.env["ORIGIN"];. I'd still like another set of eyes on this because I did get it wrong last time.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0