Precompress wasm files#3790
Merged
Rich-Harris merged 4 commits intosveltejs:masterfrom Feb 9, 2022
stephtr:patch-1
Merged
Conversation
When enabling the `precompress` option, WebAssembly files currently aren't compressed. In my case however, compression brings me down from 4 MB to 1.5 MB, which seems to be in line with [what can be observed in the wild](https://almanac.httparchive.org/en/2021/webassembly#can-we-improve-compression).
🦋 Changeset detectedLatest commit: 0892ad7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 0892ad7 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/6203fffc6df4400008473617 |
benmccann
reviewed
Feb 9, 2022
Rich-Harris
approved these changes
Feb 9, 2022
Member
|
Thank you. Rather than worrying about keeping these in sync, this logic probably belongs in Kit itself — will open a fresh issue for that |
Contributor
Author
|
Thank you too! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabling the
precompressoption, WebAssembly files currently aren't compressed.In my case however, compression brings me down from 4 MB to 1.5 MB, which seems to be in line with what can be observed in the wild.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
just a small change
Tests
pnpm testand lint the project withpnpm lintandpnpm checkTest failing is independent of this change.
Changesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0