Skip to content

[feat] transformPage #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 15, 2022
Merged

[feat] transformPage #3914

merged 14 commits into from
Feb 15, 2022

Conversation

pixelmund
Copy link
Contributor

fixes #3511

This PR implements the transformPage option on resolve.

One question that came up was, are there or will there be more properties than html on transformPage?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2022

🦋 Changeset detected

Latest commit: 95f3106

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Would you be able to add some docs?

I have somewhat mixed feelings about this because it doesn't seem like it should be necessary, but at the same time this is definitely a friendlier API and this is a common enough usecase that I suppose it's worth it. It looks like Rich would agree it's worth it since he filed the issue request 😄 It's too bad the Request / Response API isn't nicer, but we can't do much about that. So anyway, I guess I'm in favor of this change

@pixelmund
Copy link
Contributor Author

Yeah ofc, i'll try to add docs once i got some free time.

@netlify
Copy link

netlify bot commented Feb 15, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 95f3106

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/620bcd7d791eba0008480d3d

@Rich-Harris Rich-Harris merged commit 4354402 into sveltejs:master Feb 15, 2022
@Rich-Harris
Copy link
Member

thank you!

This was referenced Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformPage
3 participants