-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[feat] transformPage #3914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] transformPage #3914
Conversation
🦋 Changeset detectedLatest commit: 95f3106 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Would you be able to add some docs?
I have somewhat mixed feelings about this because it doesn't seem like it should be necessary, but at the same time this is definitely a friendlier API and this is a common enough usecase that I suppose it's worth it. It looks like Rich would agree it's worth it since he filed the issue request 😄 It's too bad the Request / Response API isn't nicer, but we can't do much about that. So anyway, I guess I'm in favor of this change
Yeah ofc, i'll try to add docs once i got some free time. |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 95f3106 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/620bcd7d791eba0008480d3d |
thank you! |
fixes #3511
This PR implements the transformPage option on
resolve
.One question that came up was, are there or will there be more properties than
html
on transformPage?Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0