Add Netlify Functions Context to Netlify Adapter#4145
Merged
Rich-Harris merged 5 commits intosveltejs:masterfrom Feb 28, 2022
Merged
Add Netlify Functions Context to Netlify Adapter#4145Rich-Harris merged 5 commits intosveltejs:masterfrom
Rich-Harris merged 5 commits intosveltejs:masterfrom
Conversation
🦋 Changeset detectedLatest commit: b92064e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
I would expect some change to https://github.com/sveltejs/kit/blob/master/packages/adapter-netlify/README.md to document this |
Conduitry
reviewed
Feb 27, 2022
Contributor
Author
Done. |
Rich-Harris
reviewed
Feb 28, 2022
Rich-Harris
approved these changes
Feb 28, 2022
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify Functions' Handler type[1] has a
contextargument that the adapter currently drops. The context contains useful information that Endpoints may want to have access to, namely auth information[2]. This PR passes that context down to Endpoints via app. Doing this has been discussed previously in #1249, including one person patching something roughly equivalent to this change into their local repo.[1] https://github.com/netlify/functions/blob/efcf21eb6c969c73d165e01b00f33b53f3e150b5/src/function/handler.ts#L11
[2] https://docs.netlify.com/functions/functions-and-identity/
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0