adapter-vercel: Use CJS entrypoint to load ESM files#483
Merged
Rich-Harris merged 7 commits intomasterfrom Mar 12, 2021
Merged
Conversation
Replace require() with await import() Replace url.parse with new URL()
benmccann
added
bug
antony
reviewed
Mar 11, 2021
| }, | ||
| plugins: [nodeResolve(), commonjs()], | ||
| external: require('module').builtinModules | ||
| external: [...require('module').builtinModules, './server/app.js'] |
Member
There was a problem hiding this comment.
does this need to use path.join in order to work cross-platform?
Member
Author
There was a problem hiding this comment.
Nope, I built the adapter on Windows, and it properly recognizes it as an external dependency.
GrygrFlzr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require()withawait import()url.parsewith newURL().mjsfiles for ESM with a single CJSindex.jsentrypoint