-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
implement config.kit.alias
#4964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement config.kit.alias
#4964
Conversation
🦋 Changeset detectedLatest commit: ab2b77a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
config.kit.alias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good to me. main things I see are the failing tests and need to update the documentation
i just merged in your change requests, and i'll get to tests and docs today. |
some notes/questions
|
thank you! |
This PR implements
config.kit.alias
, as the proposed solution in #4734 describes.Example usage:
Notes:
config.kit.files.lib
and having it beconfig.kit.alias.$lib
, but$lib
is special for packaging and other situations.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0